gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-02 16:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Record metrics for only valid gossip blocks (#8723)

Browse Source 
N/A


  Fixes the issue where we were setting block observed timings for blocks that were potentially gossip invalid.
Thanks @gitToki for the find


Co-Authored-By: Pawan Dhananjay <pawandhananjay@gmail.com>

Co-Authored-By: Michael Sproul <michaelsproul@users.noreply.github.com>
This commit is contained in:
Pawan Dhananjay
2026-02-09 10:53:44 +05:30
committed by GitHub
parent c4437d2927
commit b8d098685f
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
beacon_node/network/src/network_beacon_processor/gossip_methods.rs
View File

@@ -1214,28 +1214,25 @@ impl<T: BeaconChainTypes> NetworkBeaconProcessor<T> {
.verify_block_for_gossip(block.clone())
.await;
if verification_result.is_ok() {
let block_root = if let Ok(verified_block) = &verification_result {
metrics::set_gauge(
&metrics::BEACON_BLOCK_DELAY_GOSSIP,
block_delay.as_millis() as i64,
);
}
let block_root = if let Ok(verified_block) = &verification_result {
// Write the time the block was observed into delay cache only for gossip
// valid blocks.
self.chain.block_times_cache.write().set_time_observed(
verified_block.block_root,
block.slot(),
seen_duration,
Some(peer_id.to_string()),
Some(peer_client.to_string()),
);
verified_block.block_root
} else {
block.canonical_root()
};
// Write the time the block was observed into delay cache.
self.chain.block_times_cache.write().set_time_observed(
block_root,
block.slot(),
seen_duration,
Some(peer_id.to_string()),
Some(peer_client.to_string()),
);
let verified_block = match verification_result {
Ok(verified_block) => {
if block_delay >= self.chain.spec.get_unaggregated_attestation_due() {