v1.1.3 (#2217 )

## Issue Addressed NA ## Proposed Changes Bump versions ## Additional Info NA
Fix false positive "State advance too slow" logs (#2218 )
2026-03-08 03:01:41 +00:00 · 2021-02-22 06:21:38 +00:00 · 2021-02-21 23:47:53 +00:00 · 2021-02-21 23:47:52 +00:00 · 2021-02-19 00:49:32 +00:00 · 2021-02-18 22:33:12 +00:00
15 changed files with 31 additions and 23 deletions
--- a/.github/workflows/cancel-previous-runs.yml
+++ b/.github/workflows/cancel-previous-runs.yml
@@ -7,7 +7,7 @@ jobs:
    timeout-minutes: 3
    steps:
      # https://github.com/styfle/cancel-workflow-action/releases
-      - uses: styfle/cancel-workflow-action@514c783 # 0.7.0
+      - uses: styfle/cancel-workflow-action@514c783324374c6940d1b92bfb962d0763d22de3 # 0.7.0
        with:
          # https://api.github.com/repos/sigp/lighthouse/actions/workflows
          workflow_id: 697364,2434944,4462424,308241,2883401,316
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -30,6 +30,8 @@ jobs:
            VERSION: ${{ needs.extract-version.outputs.VERSION }}
        steps:
            - uses: actions/checkout@v2
+            - name: Update Rust
+              run: rustup update stable
            - name: Dockerhub login
              run: |
                  echo "${DOCKER_PASSWORD}" | docker login --username ${DOCKER_USERNAME} --password-stdin
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -626,7 +626,7 @@ dependencies = [

 [[package]]
 name = "beacon_node"
-version = "1.1.1"
+version = "1.1.3"
 dependencies = [
 "beacon_chain",
 "clap",
@@ -839,7 +839,7 @@ dependencies = [

 [[package]]
 name = "boot_node"
-version = "1.1.1"
+version = "1.1.3"
 dependencies = [
 "beacon_node",
 "clap",
@@ -1610,8 +1610,7 @@ checksum = "212d0f5754cb6769937f4501cc0e67f4f4483c8d2c3e1e922ee9edbe4ab4c7c0"
 [[package]]
 name = "discv5"
 version = "0.1.0-beta.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f6f52d2228d51e8f868a37d5b5b25b82c13552b635d5b47c3a5d53855a6fc4f0"
+source = "git+https://github.com/sigp/discv5?rev=02d2c896c66f8dc2b848c3996fedcd98e1dfec69#02d2c896c66f8dc2b848c3996fedcd98e1dfec69"
 dependencies = [
 "aes-ctr",
 "aes-gcm 0.8.0",
@@ -3276,7 +3275,7 @@ dependencies = [

 [[package]]
 name = "lcli"
-version = "1.1.1"
+version = "1.1.3"
 dependencies = [
 "account_utils",
 "bls",
@@ -3648,7 +3647,7 @@ dependencies = [

 [[package]]
 name = "lighthouse"
-version = "1.1.1"
+version = "1.1.3"
 dependencies = [
 "account_manager",
 "account_utils",
@@ -7080,8 +7079,7 @@ dependencies = [
 [[package]]
 name = "warp"
 version = "0.3.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3dafd0aac2818a94a34df0df1100a7356c493d8ede4393875fd0b5c51bb6bc80"
+source = "git+https://github.com/paulhauner/warp?branch=cors-wildcard#d3fac087253287eb0f716e5d9e49d46b33a02a7d"
 dependencies = [
 "bytes 1.0.1",
 "futures 0.3.12",
--- a/beacon_node/Cargo.toml
+++ b/beacon_node/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "beacon_node"
-version = "1.1.1"
+version = "1.1.3"
 authors = ["Paul Hauner <paul@paulhauner.com>", "Age Manning <Age@AgeManning.com"]
 edition = "2018"

--- a/beacon_node/beacon_chain/src/state_advance_timer.rs
+++ b/beacon_node/beacon_chain/src/state_advance_timer.rs
@@ -286,15 +286,23 @@ fn advance_head<T: BeaconChainTypes>(
        .update_pre_state(head_root, state)
        .ok_or(Error::HeadMissingFromSnapshotCache(head_root))?;

+    // If we have moved into the next slot whilst processing the state then this function is going
+    // to become ineffective and likely become a hindrance as we're stealing the tree hash cache
+    // from the snapshot cache (which may force the next block to rebuild a new one).
+    //
+    // If this warning occurs very frequently on well-resourced machines then we should consider
+    // starting it earlier in the slot. Otherwise, it's a good indication that the machine is too
+    // slow/overloaded and will be useful information for the user.
+    let starting_slot = current_slot;
    let current_slot = beacon_chain.slot()?;
-    if final_slot <= current_slot {
+    if starting_slot < current_slot {
        warn!(
            log,
            "State advance too slow";
            "head_root" => %head_root,
            "advanced_slot" => final_slot,
            "current_slot" => current_slot,
-            "initial_slot" => initial_slot,
+            "starting_slot" => starting_slot,
            "msg" => "system resources may be overloaded",
        );
    }
--- a/beacon_node/eth2_libp2p/Cargo.toml
+++ b/beacon_node/eth2_libp2p/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Sigma Prime <contact@sigmaprime.io>"]
 edition = "2018"

 [dependencies]
-discv5 = { version = "0.1.0-beta.3", features = ["libp2p"] }
+discv5 = { git = "https://github.com/sigp/discv5 ", rev = "02d2c896c66f8dc2b848c3996fedcd98e1dfec69", features = ["libp2p"] }
 unsigned-varint = { version = "0.6.0", features = ["codec"] }
 types = { path =  "../../consensus/types" }
 hashset_delay = { path = "../../common/hashset_delay" }
--- a/beacon_node/http_api/Cargo.toml
+++ b/beacon_node/http_api/Cargo.toml
@@ -5,7 +5,7 @@ authors = ["Paul Hauner <paul@paulhauner.com>"]
 edition = "2018"

 [dependencies]
-warp = "0.3.0"
+warp = { git = "https://github.com/paulhauner/warp ", branch = "cors-wildcard" }
 serde = { version = "1.0.116", features = ["derive"] }
 tokio = { version = "1.1.0", features = ["macros","sync"] }
 tokio-stream = "0.1.2"
@@ -34,4 +34,4 @@ futures = "0.3.8"
 store = { path = "../store" }
 environment = { path = "../../lighthouse/environment" }
 tree_hash = "0.1.1"
-discv5 = { version = "0.1.0-beta.3" }
+discv5 = { git = "https://github.com/sigp/discv5 ", rev = "02d2c896c66f8dc2b848c3996fedcd98e1dfec69", features = ["libp2p"] }
--- a/beacon_node/http_metrics/Cargo.toml
+++ b/beacon_node/http_metrics/Cargo.toml
@@ -8,7 +8,7 @@ edition = "2018"

 [dependencies]
 prometheus = "0.11.0"
-warp = "0.3.0"
+warp = { git = "https://github.com/paulhauner/warp ", branch = "cors-wildcard" }
 serde = { version = "1.0.116", features = ["derive"] }
 slog = "2.5.2"
 beacon_chain = { path = "../beacon_chain" }
--- a/beacon_node/network/src/sync/range_sync/chain.rs
+++ b/beacon_node/network/src/sync/range_sync/chain.rs
@@ -963,7 +963,7 @@ impl<T: BeaconChainTypes> SyncingChain<T> {
        if self
            .to_be_downloaded
            .start_slot(T::EthSpec::slots_per_epoch())
-            > self.target_head_slot
+            >= self.target_head_slot
        {
            return None;
        }
--- a/boot_node/Cargo.toml
+++ b/boot_node/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "boot_node"
-version = "1.1.1"
+version = "1.1.3"
 authors = ["Sigma Prime <contact@sigmaprime.io>"]
 edition = "2018"

--- a/common/lighthouse_version/src/lib.rs
+++ b/common/lighthouse_version/src/lib.rs
@@ -10,7 +10,7 @@ use target_info::Target;
 /// `Lighthouse/v0.2.0-1419501f2+`
 pub const VERSION: &str = git_version!(
    args = ["--always", "--dirty=+", "--abbrev=7"],
-    prefix = "Lighthouse/v1.1.1-",
+    prefix = "Lighthouse/v1.1.3-",
    fallback = "unknown"
 );

--- a/common/warp_utils/Cargo.toml
+++ b/common/warp_utils/Cargo.toml
@@ -7,7 +7,7 @@ edition = "2018"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

 [dependencies]
-warp = "0.3.0"
+warp = { git = "https://github.com/paulhauner/warp ", branch = "cors-wildcard" }
 eth2 = { path = "../eth2" }
 types = { path = "../../consensus/types" }
 beacon_chain = { path = "../../beacon_node/beacon_chain" }
--- a/lcli/Cargo.toml
+++ b/lcli/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "lcli"
 description = "Lighthouse CLI (modeled after zcli)"
-version = "1.1.1"
+version = "1.1.3"
 authors = ["Paul Hauner <paul@paulhauner.com>"]
 edition = "2018"

--- a/lighthouse/Cargo.toml
+++ b/lighthouse/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "lighthouse"
-version = "1.1.1"
+version = "1.1.3"
 authors = ["Sigma Prime <contact@sigmaprime.io>"]
 edition = "2018"

--- a/validator_client/Cargo.toml
+++ b/validator_client/Cargo.toml
@@ -52,7 +52,7 @@ eth2_keystore = { path = "../crypto/eth2_keystore" }
 account_utils = { path = "../common/account_utils" }
 lighthouse_version = { path = "../common/lighthouse_version" }
 warp_utils = { path = "../common/warp_utils" }
-warp = "0.3.0"
+warp = { git = "https://github.com/paulhauner/warp ", branch = "cors-wildcard" }
 hyper = "0.14.4"
 serde_utils = { path = "../consensus/serde_utils" }
 libsecp256k1 = "0.3.5"
Author	SHA1	Message	Date
Paul Hauner	46920a84e8	v1.1.3 (#2217 ) ## Issue Addressed NA ## Proposed Changes Bump versions ## Additional Info NA	2021-02-22 06:21:38 +00:00
Paul Hauner	4362ea4f98	Fix false positive "State advance too slow" logs (#2218 ) ## Issue Addressed - Resolves #2214 ## Proposed Changes Fix the false positive warning log described in #2214. ## Additional Info NA	2021-02-21 23:47:53 +00:00
Paul Hauner	8949ae7c4e	Address ENR update loop (#2216 ) ## Issue Addressed - Resolves #2215 ## Proposed Changes Addresses a potential loop when the majority of peers indicate that we are contactable via an IPv6 address. See https://github.com/sigp/discv5/pull/62 for further rationale. ## Additional Info The alternative to this PR is to use `--disable-enr-auto-update` and then manually supply an `--enr-address` and `--enr-upd-port`. However, that requires the user to know their IP addresses in order for discovery to work properly. This might not be practical/achievable for some users, hence this hotfix.	2021-02-21 23:47:52 +00:00
Paul Hauner	8c6537e71d	v1.1.2 (#2213 ) ## Issue Addressed NA ## Proposed Changes Bump versions ## Additional Info NA	2021-02-19 00:49:32 +00:00
Paul Hauner	f8cc82f2b1	Switch back to warp with cors wildcard support (#2211 ) ## Issue Addressed - Resolves #2204 - Resolves #2205 ## Proposed Changes Switches to my fork of `warp` which contains support for cors wildcards: https://github.com/paulhauner/warp/tree/cors-wildcard I have a PR open on the `warp` repo but it hasn't had any interest from the maintainers as of yet: https://github.com/seanmonstar/warp/pull/726. I think running from a fork is the best we can do for now. ## Additional Info NA	2021-02-18 22:33:12 +00:00
Lion - dapplion	613382f304	Add slot offset computing to be downloaded slot (#2198 ) The current implementation assumes the range offset of slots downloaded on a batch to equal zero. This conflicts with the condition to consider this chain as sync. For finalized sync, it results in one extra batch being downloaded which can't be processed. CC @wemeetagain	2021-02-18 08:24:46 +00:00
Paul Hauner	1ab495738d	Fix short sha in github actions (#2210 ) ## Issue Addressed NA ## Proposed Changes Swap to a full sha as per: https://github.com/sigp/lighthouse/runs/1922773402	2021-02-18 06:18:47 +00:00
Paul Hauner	3ffee365e2	Update rustup in release action (#2206 ) ## Issue Addressed NA ## Proposed Changes Ensure the arm64 binary is build with the latest version of Rust.	2021-02-17 23:04:09 +00:00